since libip is now used in kernel, memcpy is eshewed Notes: Wed Jan 28 09:27:55 EST 2009 jmk Wed Jan 28 09:39:44 EST 2009 jmk If a job's worth doing, it's worth doing well, e.g. if the use of 'memcpy is eshewed[sic]' in one place for good reason its use elsewhere should be evaluated for change also (and a patch provided). Code which is imported substantially 'as is' from other systems would likely be exempt from such change for maintenance and stylistic reasons. Reference: /n/sources/patch/sorry/libipkern Date: Tue Jan 27 17:43:07 CET 2009 Signed-off-by: quanstro@quanstro.net Reviewed-by: geoff --- /sys/src/libip/parseip.c Tue Jan 27 17:43:02 2009 +++ /sys/src/libip/parseip.c Tue Jan 27 17:43:00 2009 @@ -179,6 +179,6 @@ if(i > 0) *a = ~((1<<(8-i))-1); } else - memcpy(mask, defmask(addr), IPv4addrlen); + memmove(mask, defmask(addr), IPv4addrlen); return p; }