# HG changeset patch # User Francisco J Ballesteros # Date 1316631521 0 # Node ID fd2dce961f23395f459ad8d78340c90ff1898241 # Parent 065abf1e0379f8ab69174dce3fe469f3504cf47d fixes: more ignores, codereview.plan9, acpi This adds more directories to .hgignore, like srv, fd, mnt, ... in case anyone uses hg within Plan 9. Doing this, and mounting the root again using a new connection, and using that dir to run hg seems to be enough to get hg happy. Otherwise it would enter directories that have devices... the coderevivew.py for plan 9 has been changed to ignore /sys/log in changes, and also not to ask the user when it sees a new file. Otherwise, you'd get a prompt for each file you have create but do not want to submit. physalloc.c has a fix so that if acpi reports as a domain id a number < 0 the kernel would panic instead of crashing in some other way. It should help detect problems. R=nix-dev, rminnich CC=nix-dev http://codereview.appspot.com/5082042 diff -r 065abf1e0379 -r fd2dce961f23 .hgignore --- a/.hgignore Tue Sep 20 18:37:43 2011 +0200 +++ b/.hgignore Wed Sep 21 18:58:41 2011 +0000 @@ -1,9 +1,17 @@ syntax: regexp ^lib/font/bit/ ^usr/ +^tmp/ ^amd64/bin/ ^386/bin/ ^acme/bin/ +^mail/ +^proc/ +^n/ +^srv/ +^fd/ +^mnt/ +^dev/ syntax: glob *.a *.a[568] @@ -11,3 +19,7 @@ y.tab.[ch] y.debug [568].* +tmp +dev +mnt +proc diff -r 065abf1e0379 -r fd2dce961f23 sys/lib/codereview/codereview.py.plan9 --- a/sys/lib/codereview/codereview.py.plan9 Tue Sep 20 18:37:43 2011 +0200 +++ b/sys/lib/codereview/codereview.py.plan9 Wed Sep 21 18:58:41 2011 +0000 @@ -131,7 +131,7 @@ ####################################################################### # RE for files ignored for hg change unless -a is given. -ignored_for_change = "((^(386|amd64)/(lib|bin)/)|(386/init$)|(amd64/init$)|(^acme/bin/)|(\.[568]$)|(/[568]\.))" +ignored_for_change = "((^(386|amd64)/(lib|bin)/)|(386/init$)|(amd64/init$)|(^acme/bin/)|(\.[568]$)|(/[568]\.)|(^sys/log/))" ####################################################################### diff -r 065abf1e0379 -r fd2dce961f23 sys/src/nix/k10/physalloc.c --- a/sys/src/nix/k10/physalloc.c Tue Sep 20 18:37:43 2011 +0200 +++ b/sys/src/nix/k10/physalloc.c Wed Sep 21 18:58:41 2011 +0000 @@ -320,10 +320,11 @@ } if(m == 0) for(i = 0; i < ndoms; i++) - if((m = xphysalloc(&bal[i], size)) != 0){ - *colorp = i; - return m; - } + if(bal[i].kmin > 0) + if((m = xphysalloc(&bal[i], size)) != 0){ + *colorp = i; + return m; + } return m; } @@ -444,8 +445,8 @@ * that there is no interleaving of domains. Ok by now. */ DBG("physmem block dom %d addr %#ullx size %#ullx\n", dom, addr, len); - if(dom >= Ndoms) - panic("dom %d too large", dom); + if(dom < 0 || dom >= Ndoms) + panic("physinit: dom %d", dom); b = &bal[dom]; if(dom >= ndoms) ndoms = dom+1;