# HG changeset patch
# User Francisco J Ballesteros <nemo.mbox@gmail.com>
# Date 1316367897 -7200
# Node ID 87a53ed24152dc561b2755f3b7071b867a1dedfb
# Parent  6320eda391c778a5b5608dfa448e00ac2c659aab
no async msgs: make codereview report diags synchronously
This is both a test of the change and a request to review it :)
It's always very confusing that codereview prints in a background
thread status messages while it is asking for passwords and
other things. It seems that, earlier, the code did print diags
synchronously. I'm giving that a try again to see if I can see
when this damn thing asks for a password.

R=nix-dev, nemo, rminnich
CC=nix-dev
http://codereview.appspot.com/5030056

diff -r 6320eda391c7 -r 87a53ed24152 sys/lib/codereview/codereview.py
--- a/sys/lib/codereview/codereview.py	Sun Sep 18 19:43:59 2011 +0200
+++ b/sys/lib/codereview/codereview.py	Sun Sep 18 19:44:57 2011 +0200
@@ -545,11 +545,16 @@
 
 global_status = None
 
+# make set_status report the status directly, otherwise,
+# despite efforts in other functions, messages are mixed
+# with requests for passwords, and things become very
+# confussing.
 def set_status(s):
-	# print >>sys.stderr, "\t", time.asctime(), s
-	global global_status
-	global_status = s
-
+	print >>sys.stderr, "\t", time.asctime(), s
+#	global global_status
+#	global_status = s
+
+#unused
 class StatusThread(threading.Thread):
 	def __init__(self):
 		threading.Thread.__init__(self)
@@ -569,6 +574,7 @@
 				s = "(unknown status)"
 			print >>sys.stderr, time.asctime(), s
 
+#unused
 def start_status_thread():
 	t = StatusThread()
 	t.setDaemon(True)  # allowed to exit if t is still running
@@ -1562,7 +1568,7 @@
 def reposetup(ui, repo):
 	global original_match
 	if original_match is None:
-		start_status_thread()
+#		start_status_thread()
 		original_match = cmdutil.match
 		cmdutil.match = ReplacementForCmdutilMatch
 		RietveldSetup(ui, repo)