# HG changeset patch # User Erik Quanstrom # Date 1322730566 -3600 # Node ID 80599305e5fb2bf57a2ef58088086d8c4656f18b # Parent 4a60adf2f5c91276044f591edc4e30f20ec14504 6l: 8l: emit diagnostic for loop too long diagnostic was already there, but the test had && when || was intended. R=nixiedev, quanstro, Charles.Forsyth, nemo CC=nix-dev http://codereview.appspot.com/5438062 Committer: Francisco J Ballesteros diff -r 4a60adf2f5c9 -r 80599305e5fb sys/src/cmd/6l/span.c --- a/sys/src/cmd/6l/span.c Thu Dec 01 10:07:10 2011 +0100 +++ b/sys/src/cmd/6l/span.c Thu Dec 01 10:09:26 2011 +0100 @@ -1385,7 +1385,7 @@ q = p->pcond; if(q) { v = q->pc - p->pc - 2; - if(v < -128 && v > 127) + if(v < -128 || v > 127) diag("loop too far: %P", p); *andptr++ = op; *andptr++ = v; diff -r 4a60adf2f5c9 -r 80599305e5fb sys/src/cmd/8l/span.c --- a/sys/src/cmd/8l/span.c Thu Dec 01 10:07:10 2011 +0100 +++ b/sys/src/cmd/8l/span.c Thu Dec 01 10:09:26 2011 +0100 @@ -1061,7 +1061,7 @@ q = p->pcond; if(q) { v = q->pc - p->pc - 2; - if(v < -128 && v > 127) + if(v < -128 || v > 127) diag("loop too far: %P", p); *andptr++ = op; *andptr++ = v;