keep a few more functions static. noticed during work on 40gbe driver. Reference: /n/atom/patch/applied2013/static82598 Date: Mon Nov 11 22:20:01 CET 2013 Signed-off-by: quanstro@quanstro.net --- /sys/src/nix/k10/ether82598.c Mon Nov 11 22:19:38 2013 +++ /sys/src/nix/k10/ether82598.c Mon Nov 11 22:19:38 2013 @@ -217,7 +217,7 @@ char *name; }; -Stat stattab[] = { +static Stat stattab[] = { 0x4000, "crc error", 0x4004, "illegal byte", 0x4008, "short packet", @@ -374,7 +374,7 @@ static Rbpool rbtab[Nctlr]; static int nctlr; -char* +static char* cname(Ctlr *c) { return cttab[c->type].name; --- /sys/src/9/pc/ether82598.c Mon Nov 11 22:19:38 2013 +++ /sys/src/9/pc/ether82598.c Mon Nov 11 22:19:38 2013 @@ -217,7 +217,7 @@ char *name; }; -Stat stattab[] = { +static Stat stattab[] = { 0x4000, "crc error", 0x4004, "illegal byte", 0x4008, "short packet", @@ -374,7 +374,7 @@ static Rbpool rbtab[Nctlr]; static int nctlr; -char* +static char* cname(Ctlr *c) { return cttab[c->type].name; @@ -1110,15 +1110,10 @@ case 0x10f9: /* 82599 cx4 */ case 0x10fb: /* 82599 sfi/sfp+ */ case 0x10fc: /* 82599 xaui */ - case 0x1414: /* x520 kx4 mezz */ case 0x151c: /* 82599 base t kx/kx4 “niantic” */ - case 0x154a: /* x520-4 */ - case 0x154d: /* x520-q1 */ - case 0x1558: /* x520-q1 */ type = i82599; break; case 0x1528: /* x540-at2 “twinville” */ - case 0x1560: type = x540; break; default: --- /sys/src/9/pcpae/ether82598.c Mon Nov 11 22:19:38 2013 +++ /sys/src/9/pcpae/ether82598.c Mon Nov 11 22:19:38 2013 @@ -217,7 +217,7 @@ char *name; }; -Stat stattab[] = { +static Stat stattab[] = { 0x4000, "crc error", 0x4004, "illegal byte", 0x4008, "short packet", @@ -374,7 +374,7 @@ static Rbpool rbtab[Nctlr]; static int nctlr; -char* +static char* cname(Ctlr *c) { return cttab[c->type].name; @@ -1110,15 +1110,10 @@ case 0x10f9: /* 82599 cx4 */ case 0x10fb: /* 82599 sfi/sfp+ */ case 0x10fc: /* 82599 xaui */ - case 0x1414: /* x520 kx4 mezz */ case 0x151c: /* 82599 base t kx/kx4 “niantic” */ - case 0x154a: /* x520-4 */ - case 0x154d: /* x520-q1 */ - case 0x1558: /* x520-q1 */ type = i82599; break; case 0x1528: /* x540-at2 “twinville” */ - case 0x1560: type = x540; break; default: