attempt to address crash seen on 9fans

On Sat May 24 02:46:08 EDT 2014, vu3rdd@gmail.com wrote:
> I downloaded the usbinstamd64 image from the 9atom webpage and booted
> it up. First, I tried amd64 (selection 0), in a second or so, some
> text went past the screen quickly and the machine rebooted. I then
> tried selection 1 (386pae), that booted up but quickly halted with
> this:
> 
> Plan 9
> E820: ....
> ...
> apic: 6 machs started; flat mode vectors
> winbont ffff.ff hw fff8
>   no capabilities
> panic: kernel fault: no user process pc=f0162415 addr=0x000000a8
> panic: kernel fault: no user process pc=f0162415 addr=0x000000a8
> dumpstack disabled
> cpu0: exiting
> cpu0: spurious interrupt 39, last 0
> 
> and it hangs there.
> 
> Is there any options I can try to move past this step?
> -- 
>   Ramakrishnan
> 

well, first sorry.  this is not a usb issue.  since you're using
the 9paed kernel, this is the crash site:

acid; src(0xf0162415)
/sys/src/9/pcpae/ether8169.c:385
 380	static int
 381	rtl8169miimiw(Mii *mii, int pa, int ra, int data)
 382	{
 383		if(pa != 1)
 384			return -1;
>385		return ·rtl8169miimiw(mii->ctlr, pa, ra, data);
 386	}
 387	
 388	static Mii*
 389	rtl8169mii(Ctlr* ctlr)
 390	{

and after a little inspection, i see the issue.  does the amd64 kernel
behave differently?

one thing i am confused about, you have

> panic: kernel fault: no user process pc=f0162415 addr=0x000000a8
> panic: kernel fault: no user process pc=f0162415 addr=0x000000a8

i assume this was typed by hand?  if not, i'm not sure which kernel you're
running.  it should read
> panic: kernel fault: no user process pc=0xf0162415 addr=0x000000a8

Reference: /n/atom/patch/applied/mii8169crash
Date: Sat May 24 16:19:23 CES 2014
Signed-off-by: quanstro@quanstro.net

--- /sys/src/9/pcpae/ether8169.c	Sat May 24 16:19:02 2014
+++ /sys/src/9/pcpae/ether8169.c	Sat May 24 16:19:03 2014
@@ -408,8 +408,8 @@
 	phy = mii->curphy;
 	switch(ctlr->macv){
 	case Macv28:
-		rtl8169miimiw(ctlr->mii, 1, 0x1f, 0);		/* power up phy */
-		rtl8169miimiw(ctlr->mii, 1, 0x1e, 0);
+		rtl8169miimiw(mii, 1, 0x1f, 0);		/* power up phy */
+		rtl8169miimiw(mii, 1, 0x1e, 0);
 	}
 	dprint("oui %#ux phyno %d, macv = %#8.8ux phyv = %#4.4ux\n",
 		phy->oui, phy->phyno, ctlr->macv, ctlr->phyv);
--- /sys/src/9/pc/ether8169.c	Sat May 24 16:19:05 2014
+++ /sys/src/9/pc/ether8169.c	Sat May 24 16:19:07 2014
@@ -408,8 +408,8 @@
 	phy = mii->curphy;
 	switch(ctlr->macv){
 	case Macv28:
-		rtl8169miimiw(ctlr->mii, 1, 0x1f, 0);		/* power up phy */
-		rtl8169miimiw(ctlr->mii, 1, 0x1e, 0);
+		rtl8169miimiw(mii, 1, 0x1f, 0);		/* power up phy */
+		rtl8169miimiw(mii, 1, 0x1e, 0);
 	}
 	dprint("oui %#ux phyno %d, macv = %#8.8ux phyv = %#4.4ux\n",
 		phy->oui, phy->phyno, ctlr->macv, ctlr->phyv);
--- /sys/src/nix/k10/ether8169.c	Sat May 24 16:19:08 2014
+++ /sys/src/nix/k10/ether8169.c	Sat May 24 16:19:10 2014
@@ -408,8 +408,8 @@
 	phy = mii->curphy;
 	switch(ctlr->macv){
 	case Macv28:
-		rtl8169miimiw(ctlr->mii, 1, 0x1f, 0);		/* power up phy */
-		rtl8169miimiw(ctlr->mii, 1, 0x1e, 0);
+		rtl8169miimiw(mii, 1, 0x1f, 0);		/* power up phy */
+		rtl8169miimiw(mii, 1, 0x1e, 0);
 	}
 	dprint("oui %#ux phyno %d, macv = %#8.8ux phyv = %#4.4ux\n",
 		phy->oui, phy->phyno, ctlr->macv, ctlr->phyv);